Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated descrption with Sans Serif Font Family#52 #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TauqeerAhmad5201
Copy link

@TauqeerAhmad5201 TauqeerAhmad5201 commented May 5, 2023

For Issue #52, I've updated the description from Source Han Sans to Sans Serif Font Family For Pan-CJK Texts

Description

As per the issue #52 , we have to modify the description of Source Han Sans in data/server.json. So I've updated the description tag for Sans Serif Font Family to have the text in description box.

Related Issue

Attaching to the issue #52

Here I am updating the server.json file with the font requirement of Sans Serif Font Family.

Motivation and Context

This change is necessary as Sans Serif Font family will be more adaptable on the description tag while on adobe.github.com

How Has This Been Tested?

The font family shows the proper text and font now.
I ran using the nodemon index.js for the node.js backend.

Screenshots (if appropriate):

AdobeOSS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

For Issue adobe#52, I've updated the description from Source Han Sans to Sans Serif Font Family For Pan-CJK Texts
@TauqeerAhmad5201 TauqeerAhmad5201 changed the title Updated descrption with Sans Serif Font Family Updated descrption with Sans Serif Font Family#52 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant